Skip to content

Auto-update dependencies. #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Auto-update dependencies. #2711

merged 1 commit into from
Aug 13, 2025

Conversation

dpebot
Copy link
Collaborator

@dpebot dpebot commented Aug 7, 2025

Brought to you by your friendly Repository Gardener.

@dpebot dpebot force-pushed the dpebot-repositorygardener branch 4 times, most recently from f3176b3 to 71d45a5 Compare August 11, 2025 22:08
@thatfiredev
Copy link
Member

thatfiredev commented Aug 12, 2025 •
edited
Loading

Strange, it looks like dpebot didn't update the BoM in the dependencies TOML file: repo currently has 34.0.0, but 34.1.0 is available.

Update 1: firebase/snippets-android doesn't use a TOML file for some of its modules and dpebot updated it successfuly: firebase/snippets-android#639
I suspect the TOML parsing might be broken, I'll take a look at the logs from Kokoro.

Update 2: Actually, Gradle 9 might be the rootcause for this: ben-manes/gradle-versions-plugin#948 (snippets-android hasn't upgraded to Gradle 9 yet and is still running Gradle 8). There's a workaround documented in ben-manes/gradle-versions-plugin#948 (comment)

@thatfiredev thatfiredev mentioned this pull request Aug 12, 2025
Merged
thatfiredev
thatfiredev requested changes Aug 12, 2025
View reviewed changes
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened GoogleCloudPlatform/repository-gardener#196 to address the issue mentioned above - I'll merge this PR once dpebot also updates the Firebase BoM to 34.1.0+

@dpebot dpebot force-pushed the dpebot-repositorygardener branch from 71d45a5 to b8e9c1e Compare August 12, 2025 22:11
thatfiredev
thatfiredev approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great success! 👍 👍

@thatfiredev thatfiredev merged commit 4a85465 into master Aug 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatfiredev thatfiredev thatfiredev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpebot @thatfiredev